-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Remove dependency package warnings #583
Conversation
Looks good. Have you tested on your machine? |
Import all modules of mmaction and there are no warnings or errors. Directly import a function or a class in mmdet, and the error will be raised correctly, such as "ImportError: Please install mmdet to use MaxIoUAssignerAVA." |
I forgot to test it with mmdet installed. Plz wait for minutes. |
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
- Coverage 84.13% 84.10% -0.03%
==========================================
Files 121 122 +1
Lines 8617 8633 +16
Branches 1431 1435 +4
==========================================
+ Hits 7250 7261 +11
- Misses 1015 1018 +3
- Partials 352 354 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Could you help to remove these lines : ) |
Hmm conflicts |
7077908
to
e663cf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tin_shift can not be simpily removed, you need to process it with the same step
@dreamerlin good to go? |
This PR removes dependency package warnings using
import_module_error_xxx
hooks